Goobwabber / MultiplayerCore

A Beat Saber mod that implements core custom multiplayer functionality.
MIT License
66 stars 36 forks source link

Fix ordering of MpBeatmapPacket and RecommendBeatmap #51

Closed rcelyte closed 2 months ago

rcelyte commented 2 months ago

14a499cf5b6b2501a88e540cc2a5ebd7786fbed2 switched the point for sending MpBeatmapPackets from SetLocalPlayerBeatmapLevel to SetPlayerBeatmapLevel(), switching the order of MpBeatmapPacket and RecommendBeatmap/ClearRecommendedBeatmap. Doing so breaks any code that expects custom beatmap info to be present at the time of level request.

michael-r-elp commented 2 months ago

Gotten around to checking, seems fine, everything also seemed to still work when testing with 2 players so I'll merge this.