Goobwabber / MultiplayerCore

A Beat Saber mod that implements core custom multiplayer functionality.
MIT License
66 stars 36 forks source link

NetworkConfigPatcher: add DisableGameLift patch #9

Closed roydejong closed 2 years ago

roydejong commented 2 years ago

As a precaution, it would be good if MultiplayerCore ensures forceGameLift is always turned off whenever it provides a master server override.

Some context as discussed in BT server:

so at least on PC networkConfig.forceGameLift isn't currently set to true, which is why MpCore/BT can switch servers just fine. I agree though that MultiplayerCore should manage/patch that field whenever it overrides the network config

generally speaking, and as it is on PC right now, the status API will tell the game whether it should use GameLift or not in the JSON (use_gamelift) . if GameLift isn't explicitly activated in either the config or the status it will still use a regular master server connection