Nonprofit site: Add logo and favicon to Site metadata

Good-Bids / goodbids

0 stars 0 forks source link

Nonprofit site: Add logo and favicon to Site metadata #13

Closed clatwell closed 10 months ago

clatwell commented 11 months ago

We need to give Site Admins the ability to customize the logo and favicon for a Nonprofit site. For this ticket, we're just modeling the data in WP and exposing the fields in the WP Admin

Add a logo and favicon image field to the Nonprofit Site metadata.
Wire up image upload fields for logo and favicon on the "Add a New Site" form. Both fields should be optional.

clatwell commented 10 months ago

Questions for @bd-viget and @nathan-schmidt-viget

Do WP Sites have a favicon field (by default) we can use, or do we need to add a custom field for this?
- If one already exists, we can skip the favicon step in this ticket.
Do we need to do anything special with image fields for ACF based on the WIPVIP plugin incompatibility documentation here?

bd-viget commented 10 months ago

Yes, each site has the option to set the Favicon based on the Site Logo (block). There is also a built-in "Site Icon" setting under Appearance > Customizer > Site Identity, which is linked from the Site Logo block.

Since these fields are built-in, we won't need to use ACF to modify/display them.

Can we discuss this step in the Stand-up today? I wanted to get y'all's thoughts on a different approach for onboarding new sites.

clatwell commented 10 months ago

@bd-viget - Yep, totally. I'll hold on updates to this ticket for now but noting that this ticket may actually be superfluous.

clatwell commented 10 months ago

Closing as not needed