GoodDeedsPay / gdp_issues

0 stars 0 forks source link

Mini Banner Best Size Wrong (237) #33

Open andyg54321 opened 5 years ago

andyg54321 commented 5 years ago

A. The mini-banner on RD says best size is 1350x250, but using an image of that size it's nearly impossible to get the whole banner to show, no matter how the browser window is sized.

B. As the browser window is sized the banner image area changes aspect ratio. Should maintain aspect ratio and not cut off top and bottom.

Here is a test image of 1350x250 to use in testing: 1350x250

Here is what the image looks like when used as the mini-banner from sizes XL to XS. Not one of them show the whole banner properly: gdp_minibanner_l gdp_minibanner_m gdp_minibanner_s gdp_minibanner_xl gdp_minibanner_xs

Note: Please click on the images to see the full size. The largest appears smallest because it is scaled by github preview. The images above really do go from largest to smallest if you click on them.

It is OK if XS (and maybe S) crops the banner image, but for the sizes with extra blank-space around the banner, then it should be showing the whole banner, and not cropping.