GoodDollar / Bounties

14 stars 3 forks source link

Use Formik and Yup to validate forms and data over the whole app - 2K USD worth of G$s #16

Closed johnsmith-gooddollar closed 2 years ago

johnsmith-gooddollar commented 2 years ago

Motivation

We're performing manually:

As a result:

Goals

  1. To have unified validation in forms
  2. To apply validations to the forms easily in automatic mode (without handling change events, writing own hooks etc)

Solution

To use formik for validation.

  1. On form level formik should be used. together with the yup schemas
  2. Current validation logic should be concentrated inside validation callback (currently it's splitted per each field).

Details

~44h total

visitskyworld commented 2 years ago

@johnsmith-gooddollar , I am interested in completing this issue.

johnsmith-gooddollar commented 2 years ago

@visitskyworld Okay, we need to estimate the final bounty value in G$. I will update You once we'll do it, ad of course we will update the task's description

johnsmith-gooddollar commented 2 years ago

@visitskyworld we're still discussing this task. We agreed to remove validation schemas, but there's a few questions to talk about.

I'll update You tomorrow please wait

sirpy commented 2 years ago

@johnsmith-gooddollar @visitskyworld ok that's approved

visitskyworld commented 2 years ago

Should I start work from now or are you going to create a bounty to gitcoin?

johnsmith-gooddollar commented 2 years ago

Should I start work from now or are you going to create a bounty to gitcoin?

@visitskyworld Yes you could start work from now. First of all - please join https://t.me/gooddollarbounties group Then add me (https://t.me/johnsmith_gooddollar) and write DM. You may have questions regarding the task - i'll assist You. I'll be available tomorrow from 10-11am EET. Also we could make a call that time

Regarding the gitcoin - @sirpy could you please suggest here ?

iheanyi1 commented 2 years ago

Hello @johnsmith-gooddollar is this task completed?