Upgrade react-navigation to version 6.x - 500 USD worth of G$s

johnsmith-gooddollar commented 2 years ago

Motivation

Right now the project uses a mix of v4 and v5 for navigation. Both of them are now outdated. Actual version is react-navigation v6

This may cause incompatibility issues in the further react-native upgrades, which may be needed if we want to support the newest iOS and Android devices.

Last time we had to "play" alot with the deps versions to make the app support Android API Level 30 requiring RN 0.65.x

Goals

To align all react-navigation libraries used to version 6.x
To have option to keep it up-to-date using just the package manager

Details

Upgrade guides

Key setup points

[ ] Uninstall old react-navigation libraries (native + web) 0.5h
[ ] Install new libraries (native + web) 1h

Key code changes

[ ] Replace createAppContainer with NavigationContainer 2h
[ ] Replace onNavigationStateChange with onStateChange 2h
[ ] update src/components/appNavigation/stackNavigation.js 4h

Testing

[ ] update unit tests (snapshots, mocks etc) 2h

~11.5h total

sirpy commented 2 years ago

@johnsmith-gooddollar What should they do about the "key issues known"? how can they reproduce it? when does it happen?

johnsmith-gooddollar commented 2 years ago

@johnsmith-gooddollar What should they do about the "key issues known"? how can they reproduce it? when does it happen?

@sirpy when i tried to update to 5.x in the previous year i got this runtime error during app startup.

ranjithjupaka commented 2 years ago

Hey i want to work on this issue . Please assign this to me.

sirpy commented 2 years ago

iceboxed for now

GoodDollar / Bounties