search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[BUG] Social and web links do not work. #103

Closed vldkhh closed 5 months ago

vldkhh commented 6 months ago

Should only display if there’s a value, and open a new tab / page when clicked launching the appropriate asset.

image

patpedrosa commented 6 months ago

This could be happening because we didn't provide the values when the pool was created. Either way, the contract address for this pool (last icon) should show and open on celoscan.

decentralauren commented 6 months ago

@krisbitney content for other values (besides the contract address) can be found here. .

vldkhh commented 6 months ago

@krisbitney @decentralauren we should add socials to verify it

vldkhh commented 6 months ago

@L03TJ3

L03TJ3 commented 5 months ago

@krisbitney on ViewCollective page I think it should use: https://github.com/GoodDollar/GoodCollective/blob/559ff7cc03be3a300e818fbf70421bfe6da78f1d/packages/app/src/subgraph/useSubgraphCollective.ts#L93

above query includes the socials, the other doesnt

L03TJ3 commented 5 months ago

@decentralauren for Silvi's collective all socials are already set correctly.

@sirpy if a collective is created, is it still possible to update the socials after?

krisbitney commented 5 months ago

This is fixed in https://github.com/GoodDollar/GoodCollective/pull/121

L03TJ3 commented 5 months ago

@vldkhh this is being released to dev as we speak

L03TJ3 commented 5 months ago

Confirmed in call yesterday so closing