search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[UI]: Home Page / Desktop - 1200 breakpoin #109

Closed L03TJ3 closed 5 months ago

L03TJ3 commented 5 months ago

this breakpoint which is between laptop view and tablet view breaks weird. i added a design on figma for you to check the behavior

https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC?node-id=11472:54610&mode=design#663471771

image

image

L03TJ3 commented 5 months ago

This is still not 100% fixed @krisbitney Reference for various break-point sizing: https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-%F0%9F%92%B5?type=design&node-id=12184-122717&mode=design&t=OOu5l9oDMaB4qjQm-0#679312236

Example video of current behavior: Screencast from 24-01-24 20:56:05.webm

Not included in the vid --> Larger screens should not fill up the entire screen like this: image

design: image

krisbitney commented 5 months ago

@L03TJ3 I'll take a look soon

krisbitney commented 5 months ago

This is fixed in the open PR https://github.com/GoodDollar/GoodCollective/pull/119

L03TJ3 commented 5 months ago

@vldkhh this just got merged too dev

vldkhh commented 5 months ago

verified