search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[Bug] Canceling the stream takes user to an empty profile page #116

Closed patpedrosa closed 5 months ago

patpedrosa commented 5 months ago

Canceling a stream does not mean that the donations made so far were withdrawed, so the profile should not show empty.

Screen Shot 2024-01-18 at 09.54.49.png
krisbitney commented 5 months ago

The donations aren't being removed. I think the wallet is empty due to this error that is preventing subgraph queries:

Screenshot 2024-01-19 at 12 52 30 PM

@sirpy @L03TJ3 I don't have access to the subgraph infra. Would you be able to take a look and see what's going on?

sirpy commented 5 months ago

@krisbitney thegraph is a free service, we dont have any special access. Does this still happen?

krisbitney commented 5 months ago

@krisbitney thegraph is a free service, we dont have any special access. Does this still happen?

I'm no longer getting this error. Maybe it happened because I had recently redeployed the subgraph multiple times and we were rate limited, or maybe The Graph was having some issues on their end. I don't know.

@patpedrosa Could you please try again? I just tested it and my donation still showed.

I actually had the opposite problem: it took a few minutes before my profile reflected that the donation had stopped, so it looked like the donation kept flowing. My total donated amount went up to $GD 134, then reverted back to 132. The donation fetching is polled with an interval of 1 second (i.e. it checks for new data every 1 second), but it takes a short time for the transaction to finalize and the subgraph to update.

patpedrosa commented 5 months ago

I've retested it, it's showing correctly. Thank you.

krisbitney commented 5 months ago

I've retested it, it's showing correctly. Thank you.

Thank you for taking another look. I appreciate it!