GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[UI]: containers/modals should not show scrollbars #118

Closed L03TJ3 closed 5 months ago

L03TJ3 commented 5 months ago

Multiple containers and modals show a scrollbar even if there is nothing to scroll.

L03TJ3 commented 5 months ago

@vldkhh you have screenshots of the places you noticed this?

@patpedrosa @decentralauren Priority?

decentralauren commented 5 months ago

@L03TJ3 can determine priority when @vldkhh adds screen shots (cannot tell without images whether it affects UX / ability to navigate significantly).

vldkhh commented 5 months ago

@decentralauren @L03TJ3 collective page:

Snag_89d7f6.png

stewards page:

Snag_8a3568.png

donors page:

Snag_8a6c47.png

complete your donation modal :

Snag_8ac5d1.png

Donation currency and frequency:

Snag_8b2834.png

thank you modal:

Snag_8b6184.png
vldkhh commented 5 months ago

and every single modal that could appears

krisbitney commented 5 months ago

Can you please upload the photos directly so I can see them, too? Which browser are you using?

Scrollbars should only appear if content doesn't fit. I see no scrollbars myself. It would help to have more information so I can reproduce the issue locally.

decentralauren commented 5 months ago

@vldkhh I'm also unable to see the images. Can you upload directly via the ticket in github (not zenhub) maybe that will solve it?

vldkhh commented 5 months ago

@decentralauren @krisbitney how about now?

collective page: Snag_14cef52

stewards page: Snag_14d05b9

donors page: Snag_14d12d8

complete your donation modal : Snag_14d2007

Donation currency and frequency: Snag_14d313d

thank you modal: Snag_14d3fb4

krisbitney commented 5 months ago

Yes, I see. Thanks. I'll look into it. Which browser are you using?

vldkhh commented 5 months ago

@krisbitney Chrome Version 121.0.6167.86 (Official Build) (64-bit), 1920x1080 resolution

krisbitney commented 5 months ago

I downloaded Chrome and tested it, but I can't replicate the issue locally.

vldkhh commented 5 months ago

@krisbitney Lewis also can't. I noticed that on small screens there is no such issue. Pat and on her MacBook looks fine, I believe Lauren also can't replicate it For sure it is something with my PC, but what exactly?

krisbitney commented 5 months ago

I'm not sure. It would be easier to find a solution if I could replicate the issue. I will do some googling soon and get back to you.

L03TJ3 commented 5 months ago

image

@krisbitney overflow: auto

krisbitney commented 5 months ago

@L03TJ3 It's not supported in React Native. It might work on web, but you'll have to change it later for Android/iOS. Is that okay?

Screenshot 2024-01-26 at 10 58 08 AM
L03TJ3 commented 5 months ago

@krisbitney thats fine, can just suppress with ts-ignore for now

(mvp won't have the android app release any way)

krisbitney commented 5 months ago

@vldkhh Can you please tell me if the problem persists in this deployment preview? https://good-collective-plvn065n3-gooddollarteam.vercel.app/

vldkhh commented 5 months ago

@krisbitney no, looks good Snag_30ea7

L03TJ3 commented 5 months ago

Confirmed too so closing