[UX/UI]: Transactions list show more

[L03TJ3]

How to handle show more button on the transactions list

• [ ] look into lazy loading the transactions
• [ ] should it expand the list?

[decentralauren]

@L03TJ3 is this an open item that needs to be assigned to Kris?

[L03TJ3]

@decentralauren not sure. is this in scope? then yes, else no it will stay assigned to me I guess

[decentralauren]

@krisbitney I've added you to build both the "show more" functionality in web and the lazy load in mobile. We are open to adding a "show more" to both and redirecting to the appropriate page in the explorer.

[krisbitney]

@krisbitney I've added you to build both the "show more" functionality in web and the lazy load in mobile. We are open to adding a "show more" to both and redirecting to the appropriate page in the explorer.

I'm not available to add more features beyond the original requirements. I noticed those seem to have been removed from the notion today, or at least my ability to view them.

[decentralauren]

Hi @krisbitney - I don't know what notion you're referring to. We're updating the requirements to make them easier for you to implement. The original requirement which was shared in FIgma was for the transactions to load 5 at a time and then lazy load upon scroll. Here is a link to the comment.

[krisbitney]

I'm referring to the original requirements that were shared with us: https://serota.notion.site/GoodCollective-dApp-MVP-RFP-ba06e28f43e24b85aa336ad7f983c69f

[decentralauren]

@krisbitney we were clear with the team that the majority of requirements were documented as comments in the Figma with "Devs." We also walked through these with the team in detail, and you'll notice these comments were there from 7 months ago. I'm sorry that this wasn't handed over to you and explains some of the confusion with how things were implemented.

[decentralauren]

We only used the notion to document non-functional requirements or requirements not directly related to the UI. This is why the notion does not include requirements for much of the UI-related flows.

[krisbitney]

@krisbitney we were clear with the team that the majority of requirements were documented as comments in the Figma with "Devs." We also walked through these with the team in detail, and you'll notice these comments were there from 7 months ago. I'm sorry that this wasn't handed over to you and explains some of the confusion with how things were implemented.

Hmm. Okay. Let me talk to dOrg people and see if I can get a better understanding.

[krisbitney]

@krisbitney I've added you to build both the "show more" functionality in web and the lazy load in mobile. We are open to adding a "show more" to both and redirecting to the appropriate page in the explorer.

After speaking with others, it is my understanding that the Figma was not available at the time the project was scoped and the SoW was signed.

Still, if you're asking for an easier solution than lazy loading (which is easy on mobile but harder on web), then I am happy to do implement it. Could you clarify what you would like the "show more" button to do?

[krisbitney]

I think I misunderstood what you were asking for before

[krisbitney]

@decentralauren I think this is what you were asking for? https://github.com/GoodDollar/GoodCollective/pull/168

[patpedrosa]

This is what I see when I click on Show more:

[vldkhh]

@L03TJ3 @patpedrosa @decentralauren rejected, put it in Sprint

[krisbitney]

@L03TJ3 @patpedrosa @decentralauren rejected, put it in Sprint

Here is a fix for it. Sorry, it was late last night and I didn't check to make sure it worked because it's a simple change.

https://github.com/GoodDollar/GoodCollective/pull/170

It will work with this PR.

[L03TJ3]

Needs to be done the same way on mobile, that still shows the see all transactions buttons. @krisbitney

[krisbitney]

Fixed here: https://github.com/GoodDollar/GoodCollective/pull/176

[L03TJ3]

@vldkhh after qa this one is for product review to determine the initial request of loading more transactions on the page

[decentralauren]

@vldkhh has this passed QA?

[vldkhh]

@decentralauren from my perspective - yes

[github-actions[bot]]

Stale issue message