search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[Bug] Donation flow - error message after confirmation message #135

Closed decentralauren closed 5 months ago

decentralauren commented 5 months ago

Receive confirmation modal and then error modal on same transaction. Please see video for more information.

krisbitney commented 5 months ago

The video shows as being 0 seconds long. I'm not sure what happened.

The error "UNPREDICTABLE_GAS_LIMIT" is a smart contract issue.

I'm not sure how or why both the confirmation and error modal could have come up on the same transaction. Forgive me for asking, but was the confirmation modal the one that says "please confirm the transaction" or was it the one that says "thank you for your donation"?

decentralauren commented 5 months ago

Sorry @krisbitney - the original link above pointed to the wrong video. Corrected and This is the appropriate video. - let me know if you cannot view it.

There was a "Thank you, you have just donated!" modal followed by a "Something went wrong" "CALL_EXCEPTION" modal about 10 seconds later.

L03TJ3 commented 5 months ago

@krisbitney not sure if I said this in another issue but this flow can have that happen since the 'Thank you, you have just donated' shows after confirming transaction (but it does not wait for it to be completed on the blockchain)

krisbitney commented 5 months ago

@krisbitney not sure if I said this in another issue but this flow can have that happen since the 'Thank you, you have just donated' shows after confirming transaction (but it does not wait for it to be completed on the blockchain)

Okay. I can make sure the tx is confirmed before showing the thank you modal. But if I do that, do we need a Thank You modal? It was requested that the page automatically navigate to the profile page after the donation. So the Thank You modal would never be visible.

krisbitney commented 5 months ago

I think the better approach is to have the Thank You modal indicate that the transaction was submitted, not necessarily that it was confirmed. Or alternatively, it would be better not to automatically navigate to the profile page.

L03TJ3 commented 5 months ago

@patpedrosa @decentralauren likely we need a copy change here to indicate the transaction is submitted but not confirmed yet

decentralauren commented 5 months ago

@krisbitney thank you for clarifying - @L03TJ3 yes we should have another modal. can say:

"Thank you - almost done! Your transaction is pending confirmation. Please wait a few moments while it completes."

decentralauren commented 5 months ago

Closing this issue and moving this to an enhancement taken on by G$ team in this ticket