search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[BUG/iOS] Missing top nav and the grey bar appears after choosing the 'how long' donation flow #142

Closed vldkhh closed 4 months ago

vldkhh commented 5 months ago

[BUG/iOS] Missing top nav and the grey bar appears after choosing the 'how long' donation flow

Steps: 1) Navigate to https://dev-goodcollective.vercel.app/ on Safari 2) Connect your wallet 3) go to the donation flow 4) enter the amount of 'how long' 5) observe the result

Actual result: The grey bar at the bottom appears after selecting the 'how long' option. The top navigation bar is stucked

Expected result: There is no grey bar and the top nav works without any issues

Device: iPhone 13 Pro Max // iOS 17.2.1

Attachments:

https://github.com/GoodDollar/GoodCollective/assets/107620432/62c9661f-6150-4e6e-9ebe-16ee88cd1cee

decentralauren commented 5 months ago

@vldkhh can you upload the video via Github (shows as "private zenhub video" and is not visibile via github).

vldkhh commented 5 months ago

@decentralauren done

krisbitney commented 5 months ago

@vldkhh @decentralauren I'm having difficulty finding a Safari-compatible Ethereum wallet. I don't have an iPhone. Can you recommend a way for me to reproduce this bug?

patpedrosa commented 5 months ago

@krisbitney Not sure if it helps you, but I've connected on Safari using the GoodWallet (wallet.gooddollar.org) via WalletConnect.

krisbitney commented 5 months ago

@krisbitney Not sure if it helps you, but I've connected on Safari using the GoodWallet (wallet.gooddollar.org) via WalletConnect.

Thank you. I appreciate it. I'll give it a try.

patpedrosa commented 5 months ago

@krisbitney Can you simulate an iphone using Browserstack?

krisbitney commented 5 months ago

@krisbitney Can you simulate an iphone using Browserstack?

I'll check that out as well. Thank you.,

I will get this fixed, hopefully tomorrow. It's nearly 11:30pm for me right now so I won't be able to get it done tonight.

krisbitney commented 5 months ago

@vldkhh @patpedrosa I am able to replicate the issue using the iphone simulator in xcode. I don't have a fix yet, but I understand the problem. When the address bar hides itself, the page doesn't adjust to fill the screen. As a result, there is a grey space there. Likewise, when clicking an input element the screen adjusts to focus attention on it. The adjustment somehow messes with the page header.

On the bright side, the issue does not exist on Safari for desktop.

krisbitney commented 5 months ago

@vldkhh Could you check if the deployment preview in this PR fixes the issue? https://github.com/GoodDollar/GoodCollective/pull/174

vldkhh commented 5 months ago

@krisbitney still reproducing. As you can see in the video its the white bar now, and you can interact with it by holding it and scrolling up and down on the "white area".

https://github.com/GoodDollar/GoodCollective/assets/107620432/336a168a-d8d9-44ec-a51c-bb06f287026f

krisbitney commented 5 months ago

@vldkhh I believe this PR will fully fix the problem: https://github.com/GoodDollar/GoodCollective/pull/179

vldkhh commented 5 months ago

@krisbitney yes, now it working fine. Thank you

decentralauren commented 4 months ago

@patpedrosa mind retesting on your phone (you were having this issue, right?) If all good we can close :)

patpedrosa commented 4 months ago

verified - no issues