search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[Bug] recent transactions doesnt enable to see tx #143

Closed sirpy closed 5 months ago

sirpy commented 5 months ago

The tx hash is incomplete. copying the tx hash should copy the whole tx or it should link to the explorer show more also doesnt work correctly but i've seen there's a ticket about it, so not sure if its a bug.

sirpy commented 5 months ago

@patpedrosa @decentralauren FYI, please assign.

krisbitney commented 5 months ago

Worth considering: making the tx hash complete would cause it to spill over to the next line. That choice requires additional design considerations.

L03TJ3 commented 5 months ago

show more button issue is defined here: https://github.com/GoodDollar/GoodCollective/issues/124

L03TJ3 commented 5 months ago

@decentralauren @patpedrosa should we just apply the same what we did for wallet feed? truncated (first x / last x) and make the tx hash link to the explorer?

decentralauren commented 5 months ago

@L03TJ3 the transaction item should link to the explorer.

Not sure what you mean by "truncated (first x / last x)"?

krisbitney commented 5 months ago

@L03TJ3 the transaction item should link to the explorer.

Not sure what you mean by "truncated (first x / last x)"?

He means "0x12345...12345" format

krisbitney commented 5 months ago

Fixed in this PR: https://github.com/GoodDollar/GoodCollective/pull/151

L03TJ3 commented 5 months ago

@vldkhh moved to qa

vldkhh commented 5 months ago

verified. it opens the explorer with the following info by clicking on tx hash