GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

UI to associate pools and stewards with relevant NFTs #158

Open decentralauren opened 5 months ago

decentralauren commented 5 months ago

Business Requirement Each payment for direct payment GoodColllectives must trace back to the NFT that triggered the payment. This should be accessible from both the steward's wallet profile and the collective profile. As NFTs sometimes trigger multiple payments for different wallets, a new design must be created to account for and link to the NFTs Stewards were paid from, not necessarily the NFTs they hold.

(will update how to resolve with clarity from Lewis)

Slack thread

Technical Implementation

OLD DESIGN

image.png
decentralauren commented 5 months ago

@L03TJ3 Please add in description above any further detail on the "how" once we have it. Will then be in our court to update the design (just the Collectives page, right?)

github-actions[bot] commented 3 months ago

Stale issue message

L03TJ3 commented 1 week ago

@decentralauren The only thing I see possible is to just link to the transaction.

In the transaction that steward(s) are paid, is the same transaction that the NFT is minted. The NFT itself does not contain any information about all the stewards. So on chain it is not registered as being send and nft, or being owner/part of the nft.

Context: https://celoscan.io/token/0x2af5db8249229ba696e0bac1a382adb1fee040a6 Above you could track an NFT send out, for all pools. it only shows the main owner that is receiving the nft

https://celoscan.io/tx/0x4984175b47d5b387ed7a58dc97982e8a8f9e9d95292b68d33e60cbd2cabf63fd Here you see a mint-nft transaction involving two stewards.

So from my pov, the tx transaction to link to makes the most sense (we could show it on UI as NFT, but not sure if that is confusing too people)

cc: @sirpy if you have other suggestion?

decentralauren commented 4 days ago

@L03TJ3 as just discussed:

Since NFTs may pay out multiple stewards, what we display in the UI for each steward's wallet should be the NFTs that have paid out the steward (rather than the NFTs held by the steward). This is to account for future events in which 1 NFT is for 1 claim done by multiple stewards (in which multiple stewards were paid).