GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
5 stars 4 forks source link

add indication to user when data is loading #211

Closed sirpy closed 2 months ago

sirpy commented 4 months ago

Sometimes we need to wait before allowing user to perform action. like in the donate screen, when donating in a non G$ currency, we need to calculate the best uniswap exchnage path, this takes time, until that time the button should be disabled + some kind of indication to user that he needs to wait.

Currently i've added this indication as a Spinner on the button

Todo:

image.png
decentralauren commented 4 months ago

@sanajamm can you please provide guidance for Hadar? Ideally it matches other patterns / styles elsewhere in GoodCollective, Goodwallet and GoodDapp.

Maybe also see how this is handled in other dapps to find common patterns.

SanaJamm commented 4 months ago

@sirpy for some reason I can't view the image attached

sirpy commented 4 months ago

@SanaJamm are you logged in to zenhub?

image

decentralauren commented 4 months ago

@sirpy we would like to follow the same pattern as the Uniswap widget in GoodDapp (see animation below), where loading is handling by a combination of 1) a spinner in the widget which presents the info being updated and 2) a button that goes between disabled and enabled based on ability to perform the transaction.

Uniswap widget button and loading states

Do you need any additional assets to make this happen?

sirpy commented 4 months ago

i need a design. colors, where exactly the spinner is in our case and its size

decentralauren commented 2 months ago

See design in ticket https://github.com/GoodDollar/GoodCollective/issues/218

L03TJ3 commented 2 months ago

Closing this it will be part of designated buttons