Closed L03TJ3 closed 10 months ago
@L03TJ3 from my experience goodcollective is setup correctly such that when building locally it uses the local mono-repo packages and not from npm. Why is this needed?
@sirpy this is not for local development. That works fine like you say. its for the deployment of the app to vercel. when running yarn install --immutable from action-flow it relies on the local symlink references. (because of the workspace limit). and this breaks, because the mono-repo does not exist there. from that point app is its own isolated repository without any outside context of it being inside a mono-repo.
so it has the need for an explicit install of the sdk-js package from the action flow to force it to get it from npm.
The comparison can be seen here: https://github.com/GoodDollar/GoodCollective/actions/runs/6560335171 <-- failed run, cannot find dependency https://github.com/GoodDollar/GoodCollective/actions/runs/6574108936 <-- succesfull run based on above flow
This last run from the master branch? https://github.com/GoodDollar/GoodCollective/actions/runs/6495037874/job/17639177998 only works because the goodcollective-sdk is not being used in the app package yet
Then the added part for beta/latest is just for the PR's where you might be working on the app with also changes to one of the sdk packages.
Description
Improvement of feature-branch deployment flow with added support of releasing beta packages. Also fixing the installation of workspace dependency while trying to deploy. should take packages from npm-registry when live.