Closed vldkhh closed 7 months ago
@patpedrosa creating a new stream should cost roughly 0.003 (650k gas * 5gwei gasPrice)
Lewis: Base Gwei is being calculated in UI - need to hard code base Gwei being used.
@L03TJ3 to share a link.
The donation seemed too expensive (not a blocker) and it seems like the base cost is too high; @decentralauren will provide more info
Maybe this can be used/is usefull from sdk-v2 package? it enforces the base gwei price defined by celo protocol
@benefacto in the code where we do TXs it must be hardcoded with 5gwei cast costs. either in each TX, or if a global setting is possible in whatever web3 framework is used. see also lewis comment on how we created a hook that enforces that for the useDapp framework
The technical issue at hand involves the inconsistency in the gas price configuration between two different sections of code in the GoodDollar project repositories.
The inconsistency lies between two code snippets from different repositories:
GoodCollective: The gas price for chain ID 42220
(Celo) is set to 10e9
(10 Gwei).
42220: { gasPrice: 10e9, gasLimit: 1200000 },
Located at: GoodCollective Repository
GoodWeb3-Mono: The gas price for the same chain ID 42220
is set to 5e9
(5 Gwei).
case 42220:
return BigNumber.from(5e9);
Located at: GoodWeb3-Mono Repository
To maintain consistency and potentially reduce transaction costs, it is proposed that the gas price in the GoodCollective
repository be updated to match that of the GoodWeb3-Mono
repository. Specifically, the gas price for chain ID 42220
should be changed from 10 Gwei
to 5 Gwei
.
The task of harmonizing transaction costs in the GoodDollar project involves updating the gas price configuration in one repository to align with another, ensuring consistency and cost efficiency.
Review Current Configurations (1-2 hours):
GoodCollective
and GoodWeb3-Mono
repositories.Update Gas Price in GoodCollective Repository (1 hour):
42220
in the GoodCollective
repository to match the GoodWeb3-Mono
repository (from 10e9
to 5e9
).Testing and Validation (2-3 hours):
Review Implications on Transactions (2-3 hours):
Adding these up, the total estimated time could be around 6-9 hours. This estimate assumes that the developer has a good understanding of the GoodDollar project's technical infrastructure and the implications of gas price configurations on blockchain transactions.
@krisbitney This one is still existing. suggested gwei from dapp is 10 gwei where 5 is sufficient
@krisbitney This one is still existing. suggested gwei from dapp is 10 gwei where 5 is sufficient
Got it. I had thought you guys wrote the @gooddollar/goodcollective-sdk
package. I changed it there, but you may need to publish a new version on npm before the change is available in the app.
@krisbitney once https://github.com/GoodDollar/GoodCollective/pull/111/files is merged i'll trigger the publish
@krisbitney once https://github.com/GoodDollar/GoodCollective/pull/111/files is merged i'll trigger the publish
Awesome. Thanks.
goodcollective-sdk got released now, didn't really matter from what branch
Amazing, thanks. And thank you for updating the branch.
verified
Is that something that can be configured on an interface level? Why is it this expensive?