search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

Hard coded values should be dynamic #52

Closed sirpy closed 7 months ago

sirpy commented 9 months ago

Hard coded values like G$ price should be dynamic

I've noticed some places are already marked with a TODO but need to go over code and find all fixed addresses and values and verify if they should be dynamic or not

https://github.com/GoodDollar/GoodCollective/blob/895376361b63b5077ddc875f17b193cc98948663/packages/app/src/components/DonateComponent.tsx#L72

decentralauren commented 8 months ago

@sirpy can you do a short screen recording or share links for how to do the minting?

sirpy commented 8 months ago

@decentralauren its in the sdk folder readme

L03TJ3 commented 7 months ago

@sirpy @decentralauren @krisbitney is there anything left over ffor this ticket?

krisbitney commented 7 months ago

@sirpy @decentralauren @krisbitney is there anything left over ffor this ticket?

I don't think so. There isn't anything that I'm aware of.

sirpy commented 7 months ago

@L03TJ3 @krisbitney All todos have been closed? Do a manual code search for "0x..." maybe we still have some left hard coded addresses.

L03TJ3 commented 7 months ago

yes thats why I assigned myself and what I wanted to do @sirpy

krisbitney commented 7 months ago

@L03TJ3 Would you consider this issue completed? It looks like your PR is changing how immutable constants are handled, not dynamic values, so I don't think it's related to this issue.

L03TJ3 commented 7 months ago

@krisbitney see my last comment there. So yes this is closed

And to clarify whatever I did was for ourselves in case we want to support our dev tokens. I did it myself as it was out of scope