Closed krisbitney closed 8 months ago
The following PR should unblock progress: https://github.com/GoodDollar/GoodCollective/pull/60
dont use window. this is a pretty big PR anything specific I should review?
I did a good bit of UI refactoring, and It would be great another pair of eyes on the UI to make sure there were no regressions.
Since this PR replaces all of the mock data with dynamic data, it would also be good to look and see if any of the actual values look strange (e.g. formatted incorrectly).
The subgraph
directory within app
fetches data from the subgraph. The only directories that depend on it are the models
and hooks
directories. Within the UI, data is fetched using the hooks in the hooks
dir. This decouples the subgraph from the UI. Looking at anything in these directories would be helpful.
This PR should resolve the following issues, so checking these is also helpful: https://github.com/GoodDollar/GoodCollective/issues/59 https://github.com/GoodDollar/GoodCollective/issues/44 https://github.com/GoodDollar/GoodCollective/issues/57 https://github.com/GoodDollar/GoodCollective/issues/52
@sirpy I tried to review the UI mostly, but I haven't got the subgraph part yet so that is maybe what you could do?
approved, but I only reviewed app/ui side
approved, but I only reviewed app/ui side
Thanks. I merged it. @sirpy can still review it when he has time.
This PR refactors the data flow to loosen coupling between data sources and the UI. In this PR, I will also implement dynamic data in the UI to replace the mock data.