GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

Subgraph update #60

Closed krisbitney closed 8 months ago

krisbitney commented 8 months ago

This PR adds updates existing entities and adds new entities to the Subgraph:

These are breaking changes.

The updates will allow us to produce all of the data required by the UI design.

Closes https://github.com/GoodDollar/GoodCollective/issues/57

Questions

How do we calculate # of people supported by a donor? As in this part of the donor profile:

Screenshot 2023-12-16 at 11 35 24 AM

what is current pool? As in this part of the ViewCollective page:

Screenshot 2023-12-18 at 12 07 19 PM

which values are guaranteed to exist in a Collective's IPFS metadata? https://github.com/GoodDollar/GoodCollective/issues/57#issuecomment-1863013539

krisbitney commented 8 months ago

Still missing subgraph factory to start collecting events for every new pool created

I don't know what this is. Please provide more information.

sirpy commented 8 months ago

Still missing subgraph factory to start collecting events for every new pool created

I don't know what this is. Please provide more information.

Every pool is a new contract, in order for subgraph to start capturing events for this pool it must be notified about this new contract. https://thegraph.com/docs/en/developing/creating-a-subgraph/#data-source-templates

krisbitney commented 8 months ago

Still missing subgraph factory to start collecting events for every new pool created

I don't know what this is. Please provide more information.

Every pool is a new contract, in order for subgraph to start capturing events for this pool it must be notified about this new contract. https://thegraph.com/docs/en/developing/creating-a-subgraph/#data-source-templates

Awesome, thanks. This has been fixed in https://github.com/GoodDollar/GoodCollective/pull/63