search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

Donation and swap execution hooks have some redundant validation logic #84

Closed krisbitney closed 5 months ago

krisbitney commented 6 months ago

consolidate the repeated lines of code in those hooks

Reference (example of the flow in one of the hooks: https://github.com/GoodDollar/GoodCollective/blob/3cae03228a3e6a08920181525a1a62c1c4de6c99/packages/app/src/hooks/useContractCalls/useSupportFlow.ts#L24

this should be handled by a simple helper or hook

L03TJ3 commented 6 months ago

@krisbitney are we talking about the same thing here? #85

krisbitney commented 6 months ago

@krisbitney are we talking about the same thing here? #85

yes, exactly

L03TJ3 commented 5 months ago

@krisbitney will you still take this one on or shall I assign myself?

krisbitney commented 5 months ago

@krisbitney will you still take this one on or shall I assign myself?

It was already done and merged awhile ago

L03TJ3 commented 5 months ago

yes this was part of the bigger BugFixes PR. so closing