search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[UI] G$ value should show with proper digits in See all Donors page #87

Closed vldkhh closed 8 months ago

vldkhh commented 8 months ago

i.e. #2 has donated 0.10 G$

image

vldkhh commented 8 months ago

@krisbitney this is not done

krisbitney commented 8 months ago

@krisbitney this is not done

Before I dive into the code, could you please check if this is a browser caching issue? You would just have to clear your browser cache for the live preview site and see if the problem persists.

I ask because it seems to be working fine for me:

Screenshot 2024-01-24 at 7 43 50 PM
L03TJ3 commented 8 months ago

@krisbitney its about the decimals. should be rounded to 2 decimals

krisbitney commented 8 months ago

@krisbitney its about the decimals. should be rounded to 2 decimals

Okay. That's not in the design spec and I hadn't heard that until now. I will change it soon.

krisbitney commented 8 months ago

@vldkhh @L03TJ3 This is fixed in https://github.com/GoodDollar/GoodCollective/pull/122

vldkhh commented 8 months ago

verified

patpedrosa commented 8 months ago

Verified on dev.