search

GoodDollar / GoodCollective

Monorepo for GoodCollective (Segmented UBI and Direct Payments Pool)
MIT License
3 stars 1 forks source link

[Mobile/IOS/BUG/UX] Connect button shows Metamask after tapping on Wallet Connect #90

Closed vldkhh closed 5 months ago

vldkhh commented 6 months ago

This button is not in line with the Figma design specs. It also shows metamask right after tapping on wallet connect.

Build: image

Design: image

decentralauren commented 6 months ago

@sanajamm @patpedrosa I thought we had different designs for mobile vs desktop (per an earlier discussion). If so can you please be more clear of which one is supposed to show here and why?

krisbitney commented 5 months ago

@vldkhh Okay, I think I misunderstood this request before when the pics weren't loading. You are saying you want the WalletConnect logo to appear on the Connect Wallet button? In at least one of the Figma design items, the logo is not there.

I think maybe there was some confusion because the Connect Wallet button provides the option to connect with WalletConnect or MetaMask. After you connect your wallet, the Connect Wallet button is no longer visible.

Could you please clarify exactly how this is supposed to look and behave? Under what condition should the WalletConnect logo be added to the button text?

krisbitney commented 5 months ago

When I "fixed" this before, I thought you were just saying the order in which MetaMask and WalletConnect appeared in the menu was wrong. So I switched their places.

L03TJ3 commented 5 months ago

@krisbitney MetaMask is not an option on mobile as an injected provider. so just to clarify the request is/was to only show wallet-connect on mobile, indicated with a wallet-connect icon in the button

krisbitney commented 5 months ago

Okay. This is what is in the Figma. Can you please clarify: if the mobile button only supports WalletConnect, do you still want a dropdown menu to open or do you want a button click to immediately try to use WalletConnect?

Screenshot 2024-01-30 at 12 22 14 PM
L03TJ3 commented 5 months ago

@patpedrosa Think we can just do with a button click no dropdown right?

krisbitney commented 5 months ago

@L03TJ3 @patpedrosa @vldkhh This PR adds the WalletConnect logo and removes the dropdown on mobile: https://github.com/GoodDollar/GoodCollective/pull/131

krisbitney commented 5 months ago

@vldkhh Could you please review this again now that the PR is merged?

vldkhh commented 5 months ago

@krisbitney looks like it fixed img_3510_720