Extract SimpleDAIStaking into an abstract contract AbstractGoodStaking

GoodDollar / GoodContracts

GoodDollar's solidity contracts - Token + DAP based on DAOStack

MIT License

33 stars 23 forks source link

Extract SimpleDAIStaking into an abstract contract AbstractGoodStaking #160

Closed reemaSomish closed 4 years ago

reemaSomish commented 4 years ago

Details :

- [x] Create interface AbstractGoodStaking with all functions, data and event declarations for Staking Contract.
- [x] The following functions need to be added to this interface
  - stake
  - withdrawStake
  - currentERC20Worth
  - currentUBIInterest
    - collectUBIInterest

PremSOMISH commented 4 years ago

Task is completed by my side but yet to be pushed into git.

PremSOMISH commented 4 years ago

Pushed above task into git.

commit id: 01558a4fd9090ce06516c5df4a50b19d16e4f89e

PremSOMISH commented 4 years ago

Gone through your suggestions in PR #168 and responded for few comments where I needed your inputs. please go through my replies and let me know. Fixed the code according to your suggestions where we were on same page. you can find the changes here.

PremSOMISH commented 4 years ago

I have gone through your comments in PR168 and replied my thoughts. Please let me know your suggestions if any.
Worked on your suggestions in PR168 you can find the changes here.