GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Add users face record id ID to the user profile #2013

Closed tomerGD closed 4 years ago

tomerGD commented 4 years ago

Add faceVerification ID to the users' profile

  1. how to get "face record ID":
import UserStorage from '../../../../lib/gundb/UserStorage'

const enrollmentIdentifier = UserStorage.getFaceIdentifier()

working example in src/components/dashboard/FaceVerification/screens/VerificationScreen.js

  1. image is just an avatar, not the actual Zoom's recordings. so we don't need to add additional logic to catch & store imaghe captured

  2. copy button is an customized CopyButton. it should work as other copy button. No permissions should be asked as clipboard-write is automatically granted

  3. Design

https://xd.adobe.com/view/5aa4b4f5-43d6-4b67-7425-8f5f02d5d5bb-2c95/

Screen Shot 2020-06-16 at 13.25.06.png

sirpy commented 4 years ago

where should it appear? we show private details only in the "edit profile" otherwise they are ****

LiavGut commented 4 years ago

@tomerGD What is this for?

LiavGut commented 4 years ago

@sirpy Add user face record ID to the profile privacy screen.

https://xd.adobe.com/view/5aa4b4f5-43d6-4b67-7425-8f5f02d5d5bb-2c95/

Screen Shot 2020-06-16 at 13.25.06.png

serdiukov-o-nordwhale commented 4 years ago

@sirpy @LiavGut Image in "My face record ID" could be an avatar or it should be exactly an capture result we've got during FR ?

sirpy commented 4 years ago

avatar

serdiukov-o-nordwhale commented 4 years ago

Ok, thanks

serdiukov-o-nordwhale commented 4 years ago

@yaroslav-fedyshyn-nordwhale

  1. To get "face record ID" you need just:
import UserStorage from '../../../../lib/gundb/UserStorage'

const enrollmentIdentifier = UserStorage.getFaceIdentifier()

see src/components/dashboard/FaceVerification/screens/VerificationScreen.js

  1. image is just an avatar, not the actual Zoom's recordings. so we don't need to add additional logic to catch & store imaghe captured

  2. copy button is an customized CopyButton. it should work as other copy button. No permissions should be asked as clipboard-write is automatically granted

AnastasiiaOdnoshevna commented 4 years ago

@yaroslav-fedyshyn-nordwhale according to the mockup, we should see only 13 characters on each side of the "...". 2020-06-24_14-44-20.png

yaroslav-fedyshyn-nordwhale commented 4 years ago

@AnastasiiaOdnoshevna I think should cut the string in case it too long and doesn't fit the one line (overflows the box borders). It will be cut for small devices - like iPhone 5s/SE

serdiukov-o-nordwhale commented 4 years ago

@yaroslav-fedyshyn-nordwhale please cut to the chars count specified in the mockup. Don't follow container dimensions. Hash should always be cut on output It's not design-related but security reason. Like credit/debit cards as generally displaying on reсeipts as 5168****1111

yaroslav-fedyshyn-nordwhale commented 4 years ago

I discussed this thing with @LiavGut - the main reason why we decided to show it like this is because of the long string do not fit a single line.

LiavGut commented 4 years ago

@serdiukov-o-nordwhale From my end, it was only a design decision, because it was too long. @sirpy Do we have security issues here that needs the key to be hashed?

sirpy commented 4 years ago

it doesnt hurt. as long as the copy button copies everything

AnastasiiaOdnoshevna commented 4 years ago

The "My Face Record ID" is displayed according to design Checked on DEV V0.24.1-5 LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106 Desktop: Windows 10 // Google Chrome 83.0.4103.116 2020-06-30_15-25-31.png

sirpy commented 4 years ago

@AnastasiiaOdnoshevna notice that the copy button doesnt have an effect like other buttons. need to watch for these things also.

AnastasiiaOdnoshevna commented 4 years ago

@sirpy added a new issue #2094