Closed tomerGD closed 4 years ago
where should it appear? we show private details only in the "edit profile" otherwise they are ****
@tomerGD What is this for?
@sirpy Add user face record ID to the profile privacy screen.
https://xd.adobe.com/view/5aa4b4f5-43d6-4b67-7425-8f5f02d5d5bb-2c95/
@sirpy @LiavGut Image in "My face record ID" could be an avatar or it should be exactly an capture result we've got during FR ?
avatar
Ok, thanks
@yaroslav-fedyshyn-nordwhale
import UserStorage from '../../../../lib/gundb/UserStorage'
const enrollmentIdentifier = UserStorage.getFaceIdentifier()
see src/components/dashboard/FaceVerification/screens/VerificationScreen.js
image is just an avatar, not the actual Zoom's recordings. so we don't need to add additional logic to catch & store imaghe captured
copy button is an customized CopyButton. it should work as other copy button. No permissions should be asked as clipboard-write is automatically granted
@yaroslav-fedyshyn-nordwhale according to the mockup, we should see only 13 characters on each side of the "...".
@AnastasiiaOdnoshevna I think should cut the string in case it too long and doesn't fit the one line (overflows the box borders). It will be cut for small devices - like iPhone 5s/SE
@yaroslav-fedyshyn-nordwhale please cut to the chars count specified in the mockup. Don't follow container dimensions. Hash should always be cut on output It's not design-related but security reason. Like credit/debit cards as generally displaying on reсeipts as 5168****1111
I discussed this thing with @LiavGut - the main reason why we decided to show it like this is because of the long string do not fit a single line.
@serdiukov-o-nordwhale From my end, it was only a design decision, because it was too long. @sirpy Do we have security issues here that needs the key to be hashed?
it doesnt hurt. as long as the copy button copies everything
The "My Face Record ID" is displayed according to design Checked on DEV V0.24.1-5 LG V30+ // Android 8.0 // Google Chrome 83.0.4103.106 Desktop: Windows 10 // Google Chrome 83.0.4103.116
@AnastasiiaOdnoshevna notice that the copy button doesnt have an effect like other buttons. need to watch for these things also.
@sirpy added a new issue #2094
Add faceVerification ID to the users' profile
working example in
src/components/dashboard/FaceVerification/screens/VerificationScreen.js
image is just an avatar, not the actual Zoom's recordings. so we don't need to add additional logic to catch & store imaghe captured
copy button is an customized CopyButton. it should work as other copy button. No permissions should be asked as clipboard-write is automatically granted
Design
https://xd.adobe.com/view/5aa4b4f5-43d6-4b67-7425-8f5f02d5d5bb-2c95/