GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

Error: torus signin failed:: Missing privateKey from torus response #3734

Open sentry-io[bot] opened 2 years ago

sentry-io[bot] commented 2 years ago

How this is possible ?

Sentry Issue: GOODDAPP-3Z5D

Error: torus signin failed:: Missing privateKey from torus response
  at call (components/auth/torus/AuthTorus.js:104:15)
...
(1 additional frame(s) were not displayed)
vldkh commented 2 years ago

@roma-hladilka still happening

sirpy commented 2 years ago

@vldkh still happening where and how? can you reproduce? please provide example

vldkh commented 2 years ago

@sirpy i see it on Sentry https://sentry.io/organizations/gooddollar/issues/2496422975/?project=1829798&referrer=github_integration image.png

vldkhh commented 2 years ago

@roma-hladilka @sirpy Need to be rechecked later. Still happening for some users

sirpy commented 2 years ago

@roma-hladilka @serdiukov-o-nordwhale i dont think there is something we can do about it.

johnsmith-gooddollar commented 2 years ago

@roma-hladilka @vldkhh should be re-checked one week after release with the new torus version

vldkhh commented 2 years ago

@roma-hladilka @johnsmith-gooddollar need to be rechecked, still happens to ~200 users everyday

johnsmith-gooddollar commented 2 years ago

added more logging: https://github.com/GoodDollar/GoodDAPP/commit/7ea5f38696929aadf7067d04bdb8a6183fe88b7b

sirpy commented 2 years ago

@serdiukov-o-nordwhale theres not much we can do about it. close this issue. and dont log.error and throw. the last code that handles the error should log it

johnsmith-gooddollar commented 2 years ago

@sirpy bit it doesn't logs the torus response and other options. i've added additional log.error just to log which object we actually receive from Torus in such cases

sirpy commented 2 years ago

@serdiukov-o-nordwhale just move the log.error to where the rethrown error is caught, or dont catch it in the first place

johnsmith-gooddollar commented 2 years ago

@sirpy ok now passing logging options via custom prop: https://github.com/GoodDollar/GoodDAPP/commit/3970f6baa0b960828ff5a1ab94bfbdb3fe53bee6