GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
102 stars 53 forks source link

Bug: Execution failed for task ':app:mergeReleaseAssets'. #4021

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Could not resolve all files for configuration ':app:releaseRuntimeClasspath'. Could not find com.eightbitlab:blurview:1.6.3. Searched in the following locations:

possibly related: https://stackoverflow.com/questions/68934039/react-native-rnuilib-5-30-0-in-react-native-0-65-1-wont-build-due-to-error

L03TJ3 commented 1 year ago

Fixed here: https://github.com/GoodDollar/GoodDAPP/commit/3e8025e83b7ed73bdb0587421309f080ace2445a

Supposedly the build error should be fixed in 4.0.0+: https://github.com/Kureev/react-native-blur/issues/444#issuecomment-1191381815

but that doesn't work out of the box, and needs additional configuration/fixes

the comment here: https://www.reddit.com/r/reactnative/comments/t4wbme/comment/hz31bd8/?utm_source=share&utm_medium=web2x&context=3

is the above fix applied

L03TJ3 commented 1 year ago

The issue around 4.0+ is with import here: https://github.com/GoodDollar/GoodDAPP/blob/3e8025e83b7ed73bdb0587421309f080ace2445a/android/app/src/main/java/org/gooddollar/MainApplication.java#L9C2-L9C45 (cant be found)

tried following some threads around it and tested the suggested fixes, but it was just one error > next

@johnsmith-gooddollar @sirpy I don't know if one of you thinks we should upgrade and do the additional fixes required or say that the current fix is sufficient?

L03TJ3 commented 1 year ago

Fixed here: https://github.com/GoodDollar/GoodDAPP/commit/9c9bc3201cbdad57a4a979b28a3d59c1c01f7185