GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 55 forks source link

fix: use sessionTopic on native to decide if new connection should be made #4058

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Based on a false-positive during local testing, the reconnect bug seemed to be fixed for both web/android. android was not correctly handled...

the request URI (and how the request is sent) for a sign transaction when deep linking is a bit different than on web environment there is a requestId in the URI which is different for every new request done on an existing connection.

this makes the original check we run on a connection request not valid because the incoming link is always different then what we cache in reference.

This PR is for adding an additional check for android-native based on sessionTopic

About # (link your issue here)

4035

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 11:37am
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/AdEueH6Xt5mKLPmqH5ygfU6CC9sh)) | [Visit Preview](https://gooddollar-delta-git-4035-wc-reconnect-an-6b7c7b-gooddollarteam.vercel.app) | | Aug 9, 2023 11:37am | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/4y8U2Yg9Dsme1BB4t5quUjorzjrv)) | [Visit Preview](https://goodid-git-4035-wc-reconnect-android-fix-gooddollarteam.vercel.app) | | Aug 9, 2023 11:37am |