GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
103 stars 53 forks source link

Add: Language selection #4066

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Fixes for language detection/selection

About # (link your issue here)

4065

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 1:15pm
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/8wvWLG2FwnY3yp6rfaBpw9ohGrrU)) | [Visit Preview](https://gooddollar-delta-git-4065-language-translations-gooddollarteam.vercel.app) | | Aug 28, 2023 1:15pm | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/591srRU1zWPifgyK4c3zzKx4TVrh)) | [Visit Preview](https://goodid-git-4065-language-translations-gooddollarteam.vercel.app) | | Aug 28, 2023 1:15pm |
L03TJ3 commented 1 year ago

awaiting design confirmation of @patpedrosa

johnsmith-gooddollar commented 1 year ago

@L03TJ3 in the case we definitely need to restart app, I suppose we need to display some red label under the selectbox e.g. "This change requires the app the be restarted". Needs to be discussed with @patpedrosa , a new PR could be opened for it

This one is ready to merge