GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
103 stars 53 forks source link

GoodWallet Ethereum support - enhancements #4083

Closed johnsmith-gooddollar closed 7 months ago

johnsmith-gooddollar commented 1 year ago
johnsmith-gooddollar commented 1 year ago
  1. those constants are used in some different screens, also some screens have own nav options it cannot just be fixed at utils/sendReceiveFlow.js and will take some time to refactor
johnsmith-gooddollar commented 12 months ago

if a single transaction does both native transfer and token transfer then they will override each other - need a solution for this

regarding this one - I had a talk with @sunela-tr we found in this case APIs will return both transactions under the same hash but with different props (e.g. transactionType, transactionSubtype). In getNativeTxs method of API.js I'm filtering out everything except transactionTypes = 'native' AND transactionSubtype <> 'zero-transfer'. So the native transaction coming with erc20 token transfer won't be processed and show in the feed and won't interfere with anything.

patpedrosa commented 7 months ago

@johnsmith-gooddollar Can this be closed?

johnsmith-gooddollar commented 7 months ago

@patpedrosa yes, the following PR was merged: https://github.com/GoodDollar/GoodDAPP/pull/4091