Closed johnsmith-gooddollar closed 7 months ago
utils/sendReceiveFlow.js
and will take some time to refactorif a single transaction does both native transfer and token transfer then they will override each other - need a solution for this
regarding this one - I had a talk with @sunela-tr
we found in this case APIs will return both transactions under the same hash but with different props (e.g. transactionType, transactionSubtype). In getNativeTxs method of API.js I'm filtering out everything except transactionTypes = 'native' AND transactionSubtype <> 'zero-transfer'
. So the native transaction coming with erc20 token transfer won't be processed and show in the feed and won't interfere with anything.
@johnsmith-gooddollar Can this be closed?
@patpedrosa yes, the following PR was merged: https://github.com/GoodDollar/GoodDAPP/pull/4091
const RECEIVE_TITLE = 'Receive G$'
with the newNavBar
substituting token name everywhere