GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
106 stars 55 forks source link

fix: make showDialogs wrapped with promise #4096

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Implement wrappedPromise logic for showDialog to handle multiple dialogs shown in succession

About # (link your issue here)

4050

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 2:10pm
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/9hqRXT6cfNLaagqEKkrJGXCiwnTz)) | [Visit Preview](https://gooddollar-delta-git-4090-bugfix-taskdialog-gooddollarteam.vercel.app) | | Sep 26, 2023 2:10pm | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/2j5skXsspu2gGcWoVPXeio6Qc395)) | [Visit Preview](https://goodid-git-4090-bugfix-taskdialog-gooddollarteam.vercel.app) | | Sep 26, 2023 2:10pm |
L03TJ3 commented 1 year ago

@johnsmith-gooddollar I went over it again. applied the await on some more dialogs the other ones if I go over the flow don't really seem to be able to block anything

johnsmith-gooddollar commented 1 year ago
  1. To make sure second dialog will be shown only after first one was closed
  2. It doesn’t breaks anything. Lewis have added await in the places it needs only
  3. Yes in this case the previous dialog promise will be resolved