Bug: wallet-connect bugs

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.

good-dapp.vercel.app

MIT License

106 stars 55 forks source link

Bug: wallet-connect bugs #4106

Open L03TJ3 opened 1 year ago

L03TJ3 commented 1 year ago

Description

We don't properly handle all possible namespace scenario's which causes to not be able to connect to certain apps.

Test SDK by wallet-connect: https://se-sdk-dapp.vercel.app/

Fix is either one of:

[x] - Test upgrade of @walletconnect/web3wallet SDK to latest
[x] - fix optional namespaces scenario
[ ] - fix signTransaction Reproduce steps (dev):
1. go to wallet connect, and connect wallet to https://se-sdk-dapp.vercel.app/
2. connect to celo mainnet (testnet does not work)
3. use signTransaction
4. approve request in wallet
5. gets rejected on dapp

Which network did you use?

Celo (Alfajores)

L03TJ3 commented 1 year ago

Not properly handling the scenario of undefined requiredNameSpaces (takes the wrong requestedChainId)

L03TJ3 commented 1 year ago

Last comment got fixed here: https://github.com/GoodDollar/GoodDAPP/commit/66b37c24bc4be123855a0299f2736f2ea3c137a3

L03TJ3 commented 10 months ago

still in progress, not sure if it will be part of today's release. but it might

L03TJ3 commented 10 months ago

This needs a couple of attempts to retest (or figure out what is actually happening) but then likely will be pushed forward to the relevant 3rd party repo's

L03TJ3 commented 10 months ago

Added issue for it on dapp-example, it does not seem to be our side (so-far): https://github.com/WalletConnect/se-sdk/issues/22 it might require some additional fixes after they fix their side. moving it to 3rd party issue for now