GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
106 stars 55 forks source link

fix: namespaces param undefined, add: namespace builder utility #4107

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

There was a bug when trying to connect to a dapp which did not define requiredNameSpaces.

as suggested by their docs, trying to handle the most common namespace use-cases can be done with their namespace utility builder.

About # (link your issue here)

4106

How Has This Been Tested?

connect wallet to and tried several requests https://se-sdk-dapp.vercel.app/

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 0:45am
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/BhHjbrYQ1Vq8NT6HTKycrvBS5wTJ)) | [Visit Preview](https://gooddollar-delta-git-4106-wc-namespaces-gooddollarteam.vercel.app) | | Oct 5, 2023 0:45am | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/v1pPoXoKQYVqWCzB3pbYQ2c7DpGo)) | [Visit Preview](https://goodid-git-4106-wc-namespaces-gooddollarteam.vercel.app) | | Oct 5, 2023 0:45am |