search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
102 stars 53 forks source link

Bug: dialogs get stuck #4115

Closed L03TJ3 closed 10 months ago

L03TJ3 commented 11 months ago

Description

We released the async dialogs as part of a bug fix. The show (error) dialogs needs to be re-verified if await is applied properly because now in some flow a user gets stuck

sirpy commented 11 months ago

await should not have been applied to old dialogs only to new dialogs that require it.

L03TJ3 commented 11 months ago

yes thats 1 mistake. the other mistake was not properly testing all the screens with dialogs as it was pretty easy to reproduce. we need to work on that

sirpy commented 11 months ago

work on what? what is the other mistake? just remove await from all the places it was added

L03TJ3 commented 11 months ago

https://github.com/GoodDollar/GoodDAPP/pull/4116 already awaiting review @sirpy

vldkhh commented 10 months ago

verified on prod