GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
106 stars 55 forks source link

fix: don't show dapp news items #4123

Closed L03TJ3 closed 1 year ago

L03TJ3 commented 1 year ago

Description

Filter items to show on newsfeed on publish tags

About # (link your issue here)

4120

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 10:29am
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/7ELJ2atiGrwGxBB96pRsZtaijiFH)) | [Visit Preview](https://gooddollar-delta-git-fix-feed-strapi-tags-gooddollarteam.vercel.app) | | Oct 25, 2023 10:29am | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/4zDfVNdbHvUDQo6wAocbiin2Dc7a)) | [Visit Preview](https://goodid-git-fix-feed-strapi-tags-gooddollarteam.vercel.app) | | Oct 25, 2023 10:29am |
L03TJ3 commented 1 year ago

@johnsmith-gooddollar @sirpy

Do you think this is enough? I wasn't really able to figure out how to filter earlier (when requesting from ceramic)

L03TJ3 commented 1 year ago

@sirpy if there are two tags, it means we always need to show (as we only have 2 tags). if this is the case. publishWallet is the first in the array (based on schema definition)

sirpy commented 1 year ago

@sirpy if there are two tags, it means we always need to show (as we only have 2 tags). if this is the case. publishWallet is the first in the array (based on schema definition)

still i would actually change it to check if tags are empty or if exists a tag publishWallet. this will be more robust if the schema changes or we add more tags

sirpy commented 1 year ago

@sirpy if there are two tags, it means we always need to show (as we only have 2 tags). if this is the case. publishWallet is the first in the array (based on schema definition)

still i would actually change it to check if tags are empty or if exists a tag publishWallet. this will be more robust if the schema changes or we add more tags

@L03TJ3 the condition