search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

fix: add eventtype for receiving bridge tx #4131

Closed L03TJ3 closed 9 months ago

L03TJ3 commented 9 months ago

Description

The bridge receive tx on the feed was set to the same type as a regular receive event. for wallet-chat integration, this means it would show up a chat icon. Without this separation of events, there would be no normal way to distinct between the two types.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 3:08pm
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/UFpbFZ2CCtWEpcqvkvX1RDWgqMTP)) | [Visit Preview](https://gooddollar-delta-git-fix-receivebridge-feedtype-gooddollarteam.vercel.app) | | Nov 14, 2023 3:08pm | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/Fj788V8DgF2n79h1SwQWkQw1VLS4)) | [Visit Preview](https://goodid-git-fix-receivebridge-feedtype-gooddollarteam.vercel.app) | | Nov 14, 2023 3:08pm |
L03TJ3 commented 9 months ago

@sirpy @johnsmith-gooddollar current fix works only for new events not sure what the best way would be to update older ones? is that through notifyEvents? somewhere else

Also not entirely sure if there are other places which should know about a receivebridge event