Closed L03TJ3 closed 9 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
good-dapp | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 22, 2023 0:29am |
@johnsmith-gooddollar @sirpy
there are two raised 'bugs' on the original issue
bug: slowely scrolling down, around the point where it minimizes the header it becomes quite buggy (if you keep scroll active) I have tried using debounce, or the debounce hook for scrolling. but for some reason ( i dont know..) nativeEvent becomes undefined by wrapping the handleScrollEnd. is there another way to handle the crossover from headerlarge > !headerlarge (minimizing header)?
When the feed is still scrolling (android) and you click on to top, it does not jump back (explanation is i think obvious, setting the offset to 0 while scrolling will just update from offset > 0 > new offset during scrolling) All the stuff I found about blocking scrolling becomes from my pov quite hacky. on I tried to use state for enabling/disabling scrolling. does not really work. any suggestions?
to me it seems the solution is to: animation - why is it buggy? it seems like it doesnt know if to open or close the top header, so the threshold should be less sensitive or that once an animation has started it needs to finish before try the reverse animation. scroll to top - only scroll to top if scrolling is not active
@johnsmith-gooddollar maybe the simple solution is to apply the same logic as now has been done for the scrollToTop button (which uses onMomentumEnd - end of scrolling) now the callback for position is called throughout scrolling and keeps track of position maybe we should just stick to only determining position when the scrolling is static again?
Description
About # (link your issue here)
4093
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: