GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

4127: send to address #4137

Closed L03TJ3 closed 9 months ago

L03TJ3 commented 9 months ago

Description

It was already implemented, but not used. so here we enable the UI so that users can send their g$'s directly to an addres

About # (link your issue here)

4127

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 2:29pm
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/8ZrW7GpgEwdtU4gS9Nn16vWy3uNz)) | [Visit Preview](https://gooddollar-delta-git-4127-send-to-address-gooddollarteam.vercel.app) | | Nov 21, 2023 2:29pm | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/6B8QYic1vJs3523pqwtKwK3fwA3N)) | [Visit Preview](https://goodid-git-4127-send-to-address-gooddollarteam.vercel.app) | | Nov 21, 2023 2:29pm |
L03TJ3 commented 9 months ago

@johnsmith-gooddollar @sirpy left-over todo-s seem to be only ui (updating a svg icon compatibility with fontello, confirming copies with the rest) technically, I currently can't think of changes needed

sirpy commented 9 months ago

@L03TJ3 make sure unit tests are passing

johnsmith-gooddollar commented 9 months ago

@L03TJ3 regarding input with 2 icons

  1. copy InputWithAdornment to the new component, call it InputWithAddons
  2. introduce new props

{
  prefixIcon: string | boolean // left-side icon name, false if hidden
  prefixDisabled: boolean
  prefixColor: string
  prefixStyle: object
  prefixIconSize: number
  onPrefixClick: Function

 // the same for the right-side
  suffixIcon: string | boolean
  suffixDisabled: boolean
  suffixColor: string
  suffixStyle: object
  suffixIconSize: number
  onSuffixClick: Function

}

3. rewrite InputWithAdornment to just render InputWithAddons passing adornment props as 'prefix' or 'suffix' ones (depending on showAdornment value)