GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

Show User's Wallet Address #4139

Closed patpedrosa closed 8 months ago

patpedrosa commented 9 months ago

We want to facilitate for our community to find their wallet addresses now that we'll be allowing them to send G$ directly to addresses.

SanaJamm commented 9 months ago

Here are screenshots and link to figma for both screens:

Receive screen:

Screen Shot 2023-11-20 at 16 41 44

https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-%F0%9F%92%B5?type=design&node-id=9799%3A9549&mode=design&t=zSFOgTBX7Ant4y0I-1

Profile:

Screen Shot 2023-11-20 at 16 26 13

https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-%F0%9F%92%B5?type=design&node-id=9799%3A42332&mode=design&t=zSFOgTBX7Ant4y0I-1

Question for devs: I changed icons in these screens, to more consistent looking icons. is it a problem to change them?

L03TJ3 commented 9 months ago

@SanaJamm its doable, but the issue is that whatever is exported from Figma is not a compatible svg with https://fontello.com fontello does not support most of svg's 'fancy' features.

For the last couple of designs I have reworked the svg with inkscape to be fontello compatible.

So its doable, it just increases dev time a bit (depending on the changes needed for the svg)

@johnsmith-gooddollar @sirpy What is the best approach here? do we keep using fontello for icons (if a design update is updating a previous fontello one) or do just replace that icon and place a svg directly?

sirpy commented 9 months ago

@L03TJ3 @SanaJamm Icons should be in a standard icon format compatible with fontello, it should not be a standalone svg

sirpy commented 9 months ago

@SanaJamm https://medium.com/mabiloft/we-designed-an-icon-font-with-figma-and-fontello-and-it-has-not-been-a-piece-of-cake-b2948973738e

Also there are tons of free "copy" icons can't we use one of them? @patpedrosa @SanaJamm https://www.flaticon.com/search?word=copy IMHO we are already spending too much time on replacing an icon @decentralauren

SanaJamm commented 9 months ago

I kept the original icons in the end, to save you the trouble, just added a new one that doesn't already exist.. the wallet one, but i made sure it works with fontello

patpedrosa commented 8 months ago

@SanaJamm Please QA this issue on http://dev.gooddollar.org

SanaJamm commented 8 months ago

background color of my wallet address and face record icons are not the same. please make them the same as my wallet address

and make the left and right padding 8px IMG_D95553FFB580-1

drptiago commented 8 months ago

We want to track every time the user copies the address and from where they are coping @L03TJ3

So let's implement the event COPY_ADDRESS and add a parameter "source" from where this come from: exportWallet receive myprofile

vldkhh commented 8 months ago

verified on prod