Closed patpedrosa closed 8 months ago
Here are screenshots and link to figma for both screens:
Receive screen:
Profile:
Question for devs: I changed icons in these screens, to more consistent looking icons. is it a problem to change them?
@SanaJamm its doable, but the issue is that whatever is exported from Figma is not a compatible svg with https://fontello.com fontello does not support most of svg's 'fancy' features.
For the last couple of designs I have reworked the svg with inkscape to be fontello compatible.
So its doable, it just increases dev time a bit (depending on the changes needed for the svg)
@johnsmith-gooddollar @sirpy What is the best approach here? do we keep using fontello for icons (if a design update is updating a previous fontello one) or do just replace that icon and place a svg directly?
@L03TJ3 @SanaJamm Icons should be in a standard icon format compatible with fontello, it should not be a standalone svg
Also there are tons of free "copy" icons can't we use one of them? @patpedrosa @SanaJamm https://www.flaticon.com/search?word=copy IMHO we are already spending too much time on replacing an icon @decentralauren
I kept the original icons in the end, to save you the trouble, just added a new one that doesn't already exist.. the wallet one, but i made sure it works with fontello
@SanaJamm Please QA this issue on http://dev.gooddollar.org
background color of my wallet address and face record icons are not the same. please make them the same as my wallet address
and make the left and right padding 8px
We want to track every time the user copies the address and from where they are coping @L03TJ3
So let's implement the event COPY_ADDRESS
and add a parameter "source" from where this come from:
exportWallet
receive
myprofile
verified on prod
We want to facilitate for our community to find their wallet addresses now that we'll be allowing them to send G$ directly to addresses.