GoodWallet - Browser incompatibility notification showing for browser in use

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.

good-dapp.vercel.app

MIT License

100 stars 53 forks source link

GoodWallet - Browser incompatibility notification showing for browser in use #4144

Open decentralauren opened 9 months ago

decentralauren commented 9 months ago

Bug Description The "oops" modal indicating that the wallet may not work correctly on this browser shows even though I'm using it in Chrome.

Steps to Reproduce 1.Go to wallet.GoodDollar.org ...

Additional Context iPhone 12 mini iOS 16.1.1 Google Chrome v119.0.6045.169

L03TJ3 commented 9 months ago

@decentralauren I have moved this to the relevant repository It is a bit confusing where the wallet started out as being called 'gooddapp' on the background. then the front-end changed for the dex from good-swap > gooddapp

So anything related to wallet.gooddollar.org --> gooddapp repository anything related to gooddapp.org --> goodprotocolui

decentralauren commented 8 months ago

@drptiago is there a way to see how many people are seeing this modal + which browser they are using? I want to know whether this is a "just me" issue or if many users are experiencing it.

drptiago commented 8 months ago

There is no information about this, I can't reproduce the error, but we probably don't have any related events. @decentralauren

decentralauren commented 8 months ago

Thanks @drptiago

@vldkhh do we think this is just bc I'm on a mini? Should we try to replicate on other devices with small screens (e.g. lower-end android)?

patpedrosa commented 7 months ago

@L03TJ3 Could this be related to the rules we set for displaying the modal, as Lauren isn't using a native iphone browser? Either way, we should not display this modal when a person is using Chrome/Safari, do you agree?

L03TJ3 commented 7 months ago

yes that obviously should not be like that @patpedrosa

decentralauren commented 7 months ago

Suggest we update the copy to just say "your phone's native browser." If there's room we can say "For example, Chrome if you use an Android phone" but many android users will use Opera or Opera mini - not sure Google's rules around how android comes pre-loaded and whether all Android users even have Chrome as a native browser...

L03TJ3 commented 7 months ago

@decentralauren chrome is separately installed from the play-store most phones have their native browser (eg. Samsung browser.. etc.)

Likely only google pixel phones have it native