Closed L03TJ3 closed 8 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
good-dapp | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 5, 2023 7:36am |
@johnsmith-gooddollar @sirpy For all new gd contracts (I didn't see a reason to start refactoring the existing code for the gd contracts) or 3rd party contracts this fix should solve it either return contractName or when its a proxy, obtain the implementation name
However, after debugging I believe to understand that for the new buygd contracts this currently would display: 'UniswapV3Pool'
According to current flow below would be the event that is registered as 'hit' as its the log for the receiving of g$'s The from address here is the uniswapv3pool. There is no way to go from that pool contract > buygdclone right? (through querying explorer)
the other 'Transfer' events in logs are the sending of the cUsd (to other receiver addresses ofcourse) and the 'Initalized' event, which holds the buygdclone address
So the questions:
@johnsmith-gooddollar @sirpy In favor of the release of tomorrow I am merging this, and make the proper showing of buygd contract part of an action item next sprint (either hotfix, or release later) The original issue 'Show contract name or address' is solved with this
Description
We used to show unknown for non-gd wallets or contracts other then bridge.
About # (link your issue here)
4079