search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

Add flow so that buy (onramp) gd transactions show name instead of UniswapV3Pool #4151

Open L03TJ3 opened 8 months ago

L03TJ3 commented 8 months ago

Description

After fix here: https://github.com/GoodDollar/GoodDAPP/commit/45895f51b5f25d3d732035ba99f830cb626a1ed5 we will show address or contract names for transactions and no longer show unknown.

For the buy-gd contracts in the current implementation it would show as: UniswapV3Pool as that is the contract doing the swap/sending of gd to account.

What should it show? @patpedrosa @sirpy

  1. BuyGD
  2. OnrampGD
  3. ??
  4. Address
patpedrosa commented 8 months ago

BuyGD

L03TJ3 commented 8 months ago

Will likely not be part of today's release as there is a unresolved discussion how to handle it properly

L03TJ3 commented 8 months ago

@sirpy is going to add additional events on contract level to make this easier to catch on wallet side. on hold for now till that is solved

L03TJ3 commented 8 months ago

The new buygd contracts are deployed with new events, so the fix required for this can be implemented now