[Feature] Profile Improvements

[patpedrosa]

We need to do some small changes to the profile to improve UX.

• [x] Add disclaimer when Editing User Profile: We had the assumption from user bug reports that some users were editing their profiles to change their credentials, so we're adding a disclaimer to the profile page that editing their profiles will not change their credentials

• [x] On edit mode, replace "nickname" to "Full name" Currently, users can't edit their full names on profile, but are allowed to edit "nicknames" that don't display anywhere. We want to use the field to now show and allow editing of their Full Names.

• [x] Show login method in User profile To help users remember how they created their wallets, we are adding a component to the profile which shows their login methods.

• [x] Replace FaceID image for icon On the profile, we're using people's uploaded image as an icon for their FaceID. That is incorrect, and also displaying square. We want to replace it for an icon, round in shape.

Figma for all changes above: https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC/3.-Product-%F0%9F%92%B5?type=design&node-id=9799-42332&mode=design&t=uIGGsZjdGb7TN3HW-0

[vldkhh]

@L03TJ3 @patpedrosa Do we want to keep this "note" on the "My Profile" page and on the "Edit profile" page? According to the design the note should be displayed on the Edit profile page

[vldkhh]

NOTE: Also, to see the login method you should logout, do a hard reset and clear the cache, then login (do it 2-4 times to see that)

[L03TJ3]

@patpedrosa @decentralauren I forgot to share this..

Basically we never really stored anywhere someone's used login-method. it was just saved as 'torus' (which says nothing to the user). So in order for the login-method to show I needed to add a new flow during login/sign-up where this get stored/saved.

Meaning, that login-method would not show anything for an already logged-in user up until they re-login (I will look into vlad's reported bug)

How to handle this? Should we just hide the whole block when we don't know the login-method (yet) ?

[patpedrosa]

@L03TJ3 Yes, that's a good solution. Better than showing blank or torus.

[sirpy]

we are saving the login method in our user database via the backend (goodserver)

[L03TJ3]

reading from database is made a separate issue here: https://github.com/GoodDollar/GoodDAPP/issues/4169 Rejected points from UAT:

• [x] - save button looks disabled (but is usable) when editing phone/email
• [x] - don't show full-name on main profile view (only show in edit mode)

[L03TJ3]

@vldkhh this can be retested on dev

1. it should now show a verify button for the phone/email fields
2. save button (next to avatar message) only shown when full-name is editted

[vldkhh]

@L03TJ3 for me it works as expected, good job! @decentralauren you can try on https://dev.gooddollar.org/

[decentralauren]

@L03TJ3 @vldkhh I keep getting stuck at the OTP (it keeps timing out and not sending). Happy to test once pushed to prod if it works well for everyone else!

Yay :)

[decentralauren]

OK I found 3 issues:

• [ ] Display issues in "View" mode on my device (iphone 12 mini - same issue that was present prior)
• [ ] Verify button appears if user re-enters same email or phone number, however does not allow user to proceed.
• [ ] after re-verifying email, I was brought back to the "View" mode rather than to the "Edit" mode displaying my updated verified email

(I have slacked a video describing these items to @vldkhh and @L03TJ3 as it has PII)

[L03TJ3]

@decentralauren above points got discussed or fixed and is already released. so is this feature review done and we can move this ticket?

[decentralauren]

@L03TJ3 Yes! Please close this ticket and thanks for following up.