GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

Wip: Rpc issues #4164

Closed L03TJ3 closed 7 months ago

L03TJ3 commented 8 months ago

Description

After report by @vldkhh, this pr is to attempt to minimize events logged based on this: https://gooddollar.sentry.io/issues/4555924288/?environment=production&project=1829798&query=&referrer=issue-stream&sort=user&statsPeriod=14d&stream_index=0

(1m+ registered events) It seems we log repeatedly the same type of events when cycling through rpc's.

Current wip fixes:

About # (link your issue here) undefined

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 0:15am
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **gooddollar-delta** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/gooddollar-delta/3G5T5VfGC7edZCQyT8ZsMtUjk5E6)) | [Visit Preview](https://gooddollar-delta-git-rpc-issues-gooddollarteam.vercel.app) | | Jan 24, 2024 0:15am | | **goodid** | ⬜️ Ignored ([Inspect](https://vercel.com/gooddollarteam/goodid/Bicytu3U3v76Ge9UJh9yZDun8suA)) | [Visit Preview](https://goodid-git-rpc-issues-gooddollarteam.vercel.app) | | Jan 24, 2024 0:15am |
L03TJ3 commented 8 months ago

@johnsmith-gooddollar based on your suggestion to 'only report when all attempts fail'

https://github.com/GoodDollar/GoodDAPP/blob/7a0edddeea2b5ad597332608a1c41bf651c53073/src/lib/utils/async.js#L78 Do I read this right that this is already the case? throws error only when fallback is false? (the check here: https://github.com/GoodDollar/GoodDAPP/blob/7a0edddeea2b5ad597332608a1c41bf651c53073/src/lib/wallet/MultipleHttpProvider.js#L62)