GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

Improve Transaction Feed & Transaction Detail (Card View) with contract name (address) #4167

Closed decentralauren closed 7 months ago

decentralauren commented 8 months ago

Transactions with Safes and similarly named contracts are hard to distinguish and identify, so we want to add a truncated wallet address to the tx feed.

Screenshot 2023-12-18 at 12.27.55 PM.png
L03TJ3 commented 8 months ago

@decentralauren should this be done on all named contracts (including ours, bridge/claim), or just the ones from third parties?

decentralauren commented 8 months ago

@patpedrosa check Lewis' comment above. Do we have other examples of where / how we should apply this?

decentralauren commented 8 months ago

@L03TJ3 this is updated, but the transaction detail card page still being worked on UI. Sana still working on this and will update the Figma @sanajamm

L03TJ3 commented 8 months ago

@decentralauren ok! I added the need design, so @SanaJamm whenever you are ready just ping me and/or remove label then I now I can continue on it :)

SanaJamm commented 8 months ago

This is the Figma for both the transaction card and the detailed card view

https://www.figma.com/file/ihw1PxBvLxacTHnN2aj4lC?node-id=10878:56509&mode=design#653885541

please notice the truncation note above the transaction card. *Truncate name after 15 characters

L03TJ3 commented 7 months ago

@patpedrosa @vldkhh I am moving this to next sprint, or if priority is needed on it we can push it later as hotfix

vldkhh commented 7 months ago

verified on prod