GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

Change copy in the "Add name" screen on wallet onboarding flow #4171

Closed decentralauren closed 7 months ago

decentralauren commented 8 months ago

Now that people can edit their names in Profile, we need to remove this screen from the onboarding flow

image.png
sirpy commented 8 months ago

@decentralauren I think this step is required otherwise their profile name will be empty If user login with facebook/google then we already capture their name, so I think this step is not shown for facebook/google signup only for passwordless

decentralauren commented 8 months ago

@sirpy - @patpedrosa and I discussed - She's confident that users will go to the Profile to update as Profile is a commonly visited page.

An alternate approach is to only show this screen as you said for passwordless logins, and to update the assistive text to "This is what people will see when you send or receive transactions. You can change it at any time in your Profile."

@patpedrosa wdyt?

patpedrosa commented 7 months ago

This is fine.

An alternate approach is to only show this screen as you said for passwordless logins, and to update the assistive text to "This is what people will see when you send or receive transactions. You can change it at any time in your Profile."

L03TJ3 commented 7 months ago

fixed here: https://github.com/GoodDollar/GoodDAPP/commit/a5a652690464f63b9a87ce2b2fdab6590d806587

vldkhh commented 7 months ago

verified on QA

vldkhh commented 7 months ago

verified on prod

Snag_405349.png