search

GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
100 stars 53 forks source link

Error: Failed with last error #4172

Closed sentry-io[bot] closed 4 months ago

sentry-io[bot] commented 8 months ago

We got 100ks of such errors. To reduce it we should modify multihttpprovider to keep cycling with RPCs. Perhaps cycle twice through RPCs before reporting an error

Sentry Issue: GOODDAPP-193NG

Error: Failed with last error
  at <object>.value (lib/analytics/AnalyticsClass.js:474:30)
  at call (lib/analytics/AnalyticsClass.js:169:48)
  at formatter (lib/logger/js-logger.js:21:15)
  at logHandler (lib/logger/js-logger.js:33:3)
  at <anonymous> (lib/wallet/MultipleHttpProvider.js:53:11)
...
(3 additional frame(s) were not displayed)
decentralauren commented 7 months ago

@johnsmith-gooddollar we are prioritizing this for sprint 6 - can you confirm you are accountable and will own this ticket?

johnsmith-gooddollar commented 7 months ago

hot fixed https://github.com/GoodDollar/GoodDAPP/commit/d7d518a070ec6a1271823c7f8a83e8871da47a9e

sirpy commented 7 months ago

default retry 1 will mean it will do 2 cycles through rpcs? @johnsmith-gooddollar

johnsmith-gooddollar commented 7 months ago

@sirpy yes

L03TJ3 commented 6 months ago

@vldkhh @sirpy @johnsmith-gooddollar there are still 220k+ events shown, 30k in last 24 hours. https://gooddollar.sentry.io/issues/4555924288/?notification_uuid=f9bb14b3-15e3-4160-ae50-9bf72133085d&project=1829798&referrer=weekly_report

There is above one: Failed with last error (nothing extra) And there are now new ones: Failed with last error:Network error on rpc X

I think there is still something that needs to be changed or fixed here?

sirpy commented 6 months ago

@L03TJ3 yes we still have too many errors logged. see #4215 for improvements

L03TJ3 commented 6 months ago

@vldkhh this just got hotfixed released

vldkhh commented 6 months ago

@L03TJ3 I don't see this error happening on 2.34.3 env, i think we need some time to monitor it. Currently we have 19k/day

vldkhh commented 6 months ago

@L03TJ3 need to rechecked - https://gooddollar.sentry.io/issues/4555924288/?project=1829798&referrer=github_integration

L03TJ3 commented 6 months ago

@vldkhh Can this be rechecked and if done closed? there is a new issue created for: Failed with last error: unknown --> https://github.com/GoodDollar/GoodDAPP/issues/4230

vldkhh commented 4 months ago

verified on prod

image.png