Error: Unhandled promise rejection at:: ENS is not supported on network private

sentry-io[bot] commented 8 months ago

We got 150k such errors This is a new error that seem to have started in 2.30.0 It seems like only from some external package. Why? web3 upgrade? the rpc string issue?

Sentry Issue: GOODDAPP-1AGFH

Error: Unhandled promise rejection at:: ENS is not supported on network private
  at call (../node_modules/web3/dist/web3.min.js:30599:25)
  at h (../node_modules/web3/dist/web3.min.js:33280:26)
  at _invoke (../node_modules/web3/dist/web3.min.js:33364:27)
  at o (../node_modules/web3/dist/web3.min.js:33305:31)
  at t (../node_modules/web3/dist/web3.min.js:33032:25)
...
(1 additional frame(s) were not displayed)

L03TJ3 commented 8 months ago

Not sure its related to the rpc string. but the fix for that has been applied here: https://github.com/GoodDollar/GoodDAPP/commit/f7709394b5d0ff769dea79bb0b1339daa9f78021 will keep track tomorrow on sentry to see if it has reduced/removed this error or that it requires more investigation

L03TJ3 commented 7 months ago

@sirpy okay the pr got closed now. The answer to your question is: I have no idea, I was unable to figure out which package uses checkNetwork from the web3-ens library which is what triggers the error log.

L03TJ3 commented 7 months ago

Rejected pr. need to dive deeper and figure out exactly which package the error comes from

GoodDollar / GoodDAPP

Error: Unhandled promise rejection at:: ENS is not supported on network private #4173