GoodDollar / GoodDAPP

GoodDollar.org Wallet is the simplest access point to Claim your daily G$. It Is based on web3 and React native web.
good-dapp.vercel.app
MIT License
108 stars 56 forks source link

Error: _notifyEvents event get/send receipt failed:: CONNECTION ERROR: Couldn't connect to node https://... #4179

Closed sentry-io[bot] closed 10 months ago

sentry-io[bot] commented 11 months ago

We can probably not error log CONNECTION ERROR in multihttpprovider This means there's a network issue on the user side

Sentry Issue: GOODDAPP-PEPP

Error: _notifyEvents event get/send receipt failed:: CONNECTION ERROR: Couldn't connect to node https://fuse.api.onfinality.io/public.
  at e.exports.ConnectionError (../node_modules/web3/dist/web3.min.js:28456:23)
  at e.exports.InvalidConnection (../node_modules/web3/dist/web3.min.js:28431:27)
  at r.<anonymous> (../node_modules/web3/dist/web3.min.js:32241:143)
decentralauren commented 10 months ago

@johnsmith-gooddollar we are prioritizing this for sprint 6 - can you confirm you are accountable and will own this ticket?

johnsmith-gooddollar commented 10 months ago

hot fixed https://github.com/GoodDollar/GoodDAPP/commit/7c95d33a5fb2f4006ab8e2012c7bed1706bee2d0

sirpy commented 10 months ago

@johnsmith-gooddollar this is not a correct fix. you stopped logging also other errors. we are talking about CONNECTION ERROR only

johnsmith-gooddollar commented 10 months ago

@sirpy right, we switch endpoint if rpc error or connection timeout or connection failed. all those 3 cases shouldn't be logged because they appear on each unsuccessful try, then are thrown in provider, caught and logged in the wallet. each case means something wrong with network connection client side or with rpc itself, not something wrong with the app and should be logged for analysis

this condition was in MultipleHttpProvider, it kept untouched (compare with older commit): https://github.com/GoodDollar/GoodDAPP/commit/7c95d33a5fb2f4006ab8e2012c7bed1706bee2d0#diff-4b3fa72276639ae4eaab0fefa25314e7bd4525895c43713576d8634a78a55a1bR290

vldkhh commented 10 months ago

22 events for last 24h. closed